Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slow aestransport and cli tests #816

Merged
merged 2 commits into from Mar 11, 2024

Conversation

sdb9696
Copy link
Collaborator

@sdb9696 sdb9696 commented Mar 7, 2024

Reduces total test time on my local from 154s to 120s

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.20%. Comparing base (3495bd8) to head (4f1904d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #816   +/-   ##
=======================================
  Coverage   89.20%   89.20%           
=======================================
  Files          63       63           
  Lines        4539     4539           
  Branches     1149     1149           
=======================================
  Hits         4049     4049           
  Misses        407      407           
  Partials       83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdb9696 sdb9696 requested a review from rytilahti March 7, 2024 18:58
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge 👍

kasa/tests/test_cli.py Show resolved Hide resolved
kasa/tests/test_cli.py Outdated Show resolved Hide resolved
@sdb9696 sdb9696 merged commit 7507837 into python-kasa:master Mar 11, 2024
29 checks passed
@sdb9696 sdb9696 deleted the fix_slow_tests branch March 11, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants