New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor split smartdevice tests to test_{iot,smart}device #822
Conversation
Wanted to clean this up a bit before adding some tests for #807. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not completely happy about the naming of this file, as it doesn't really test the Device
API at the moment, but rather some other common functionalities.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #822 +/- ##
=======================================
Coverage 89.21% 89.21%
=======================================
Files 63 63
Lines 4543 4543
Branches 1151 1151
=======================================
Hits 4053 4053
Misses 407 407
Partials 83 83 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm other than the question whether test_xxxdevice.py
should go in the subfolders.
@@ -0,0 +1,259 @@ | |||
"""Module for common iotdevice tests.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this go under an iot
folder similar to the smart
subfolder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, good catch, probably yes 😄
@@ -1,319 +1,18 @@ | |||
import importlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this go under the smart
subfolder?
EDIT: actually will merge this as it might help with history this way. Can always be moved after.
This does not add any new tests, but just reorganizes the existing ones.
test_device.py
test_smartdevice.py
test_iotdevice.py