Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ColorModule for smart devices #840

Merged
merged 4 commits into from
Apr 20, 2024
Merged

Add ColorModule for smart devices #840

merged 4 commits into from
Apr 20, 2024

Conversation

sdb9696
Copy link
Collaborator

@sdb9696 sdb9696 commented Apr 19, 2024 •
edited by rytilahti

Adds support L530 hw_version 1.0

Fixes home-assistant/core#111757

@codecov Codecov
Copy link

codecov bot commented Apr 19, 2024 •
edited

Codecov Report

Attention: Patch coverage is 90.90909% with 5 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@203bd79). Click here to learn what that means.

Files Patch % Lines
kasa/smart/modules/colortemp.py 66.66% 2 Missing and 1 partial ⚠️
kasa/smart/modules/colormodule.py 93.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #840   +/-   ##
=========================================
  Coverage          ?   89.00%           
=========================================
  Files             ?       66           
  Lines             ?     4612           
  Branches          ?     1133           
=========================================
  Hits              ?     4105           
  Misses            ?      422           
  Partials          ?       85

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdb9696 sdb9696 mentioned this pull request Apr 19, 2024
Closed
@rytilahti rytilahti added the enhancement New feature or request label Apr 19, 2024
rytilahti
rytilahti reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up! A couple of quick comments, I tested that the hsv command is still working on L530 and L900.

kasa/smart/modules/colortemp.py Outdated Show resolved Hide resolved
kasa/smart/modules/colormodule.py Show resolved Hide resolved
kasa/smart/smartbulb.py Show resolved Hide resolved
kasa/smart/smartdevice.py Show resolved Hide resolved
kasa/tests/device_fixtures.py Outdated Show resolved Hide resolved
@rytilahti rytilahti changed the title Add ColorModule to support L530 hw_version 1.0 Add ColorModule for smart devices Apr 19, 2024
rytilahti
rytilahti approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's ship it! 🚀

@rytilahti rytilahti merged commit aeb2c92 into python-kasa:master Apr 20, 2024
29 checks passed
@sdb9696 sdb9696 deleted the fix_tapo_color branch April 23, 2024 06:26
This was referenced May 19, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti rytilahti approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TP-Link Smart Home Integration Color Issue Tapo L530
2 participants
@sdb9696 @rytilahti