Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore system environment variables for tests #851

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

rytilahti
Copy link
Member

This unsets KASA_ prefixed environment variables for cli tests, avoiding the annoying failures in auth tests if you have username and password defined in your environment.

As this is a fixture, we could potentially extend this to default catch_exceptions=False for invoke().

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@203bd79). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #851   +/-   ##
=========================================
  Coverage          ?   89.00%           
=========================================
  Files             ?       65           
  Lines             ?     4583           
  Branches          ?     1130           
=========================================
  Hits              ?     4079           
  Misses            ?      420           
  Partials          ?       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked we'd still be able to use isolated_filesystem etc with the fixture approach and all looks good.

@sdb9696 sdb9696 merged commit 4573260 into master Apr 20, 2024
29 checks passed
@sdb9696 sdb9696 deleted the fix/clirunner_unset_envvars branch April 20, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants