Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use brightness module for smartbulb #853

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

rytilahti
Copy link
Member

Moves one more feature out from the smartbulb class

Moves one more feature out from the smartbulb class
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.01%. Comparing base (29b2896) to head (d577e9d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #853      +/-   ##
==========================================
- Coverage   89.01%   89.01%   -0.01%     
==========================================
  Files          66       66              
  Lines        4617     4616       -1     
  Branches     1135     1135              
==========================================
- Hits         4110     4109       -1     
  Misses        422      422              
  Partials       85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdb9696
Copy link
Collaborator

sdb9696 commented Apr 20, 2024

So I missed this copy/paste error too but not sure how the tests passed?

@rytilahti
Copy link
Member Author

The tests did not pass, that's how I noticed it :-)

@rytilahti rytilahti merged commit 651ad96 into master Apr 20, 2024
29 checks passed
@rytilahti rytilahti deleted the janitor/use_brightness_for_smartbulb branch April 20, 2024 18:29
@sdb9696
Copy link
Collaborator

sdb9696 commented Apr 20, 2024

The tests did not pass, that's how I noticed it :-)

Ugh, I missed that sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants