-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fan interface for SMART devices #873
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #873 +/- ##
==========================================
- Coverage 89.27% 89.23% -0.04%
==========================================
Files 67 68 +1
Lines 4819 4851 +32
Branches 1186 1201 +15
==========================================
+ Hits 4302 4329 +27
- Misses 427 429 +2
- Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of more nits, but I think this is otherwise ready-to-go 👍
Feel free to add a description and merge this 👍 |
Enables the Fan interface for devices supporting that component. Currently the only device with a fan is the ks240 which implements it as a child device. This PR adds a method
get_module
to search the child device for modules if it is a WallSwitch device type.