Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add child devices from hubs to generated list of supported devices #898

Merged
merged 3 commits into from
May 7, 2024

Conversation

sdb9696
Copy link
Collaborator

@sdb9696 sdb9696 commented May 3, 2024

Updates generate_supported hook to include child devices of hubs in the list of supported devices.

Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.40%. Comparing base (c5d65b6) to head (e40bf35).

Files Patch % Lines
kasa/smart/smartdevice.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #898      +/-   ##
==========================================
- Coverage   90.48%   90.40%   -0.08%     
==========================================
  Files          70       70              
  Lines        4937     4941       +4     
  Branches     1218     1220       +2     
==========================================
  Hits         4467     4467              
- Misses        380      384       +4     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing the child device categorization, feel free to merge as you wish!

devtools/generate_supported.py Outdated Show resolved Hide resolved
@sdb9696
Copy link
Collaborator Author

sdb9696 commented May 7, 2024

Categorisation changed as per comment and a note added about hub connected devices working across TAPO/KASA branded hubs even if they don't work across the native apps.

@sdb9696 sdb9696 merged commit f063c83 into master May 7, 2024
25 of 27 checks passed
@sdb9696 sdb9696 deleted the feat/add_child_supported branch May 7, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants