Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing alarm volume 'normal' #899

Merged
merged 2 commits into from
May 7, 2024
Merged

Add missing alarm volume 'normal' #899

merged 2 commits into from
May 7, 2024

Conversation

rytilahti
Copy link
Member

Also logs a warning and fixes the returned string to be consistent with valid values.

@rytilahti rytilahti added the bug Something isn't working label May 4, 2024
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.40%. Comparing base (f063c83) to head (b4f57b9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #899   +/-   ##
=======================================
  Coverage   90.40%   90.40%           
=======================================
  Files          70       70           
  Lines        4941     4941           
  Branches     1220     1220           
=======================================
  Hits         4467     4467           
  Misses        384      384           
  Partials       90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdb9696 sdb9696 merged commit 50b5107 into master May 7, 2024
27 checks passed
@sdb9696 sdb9696 deleted the fix/add_alarm_normal branch May 7, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants