Deprecate device level light, effect and led attributes #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #916 +/- ##
==========================================
+ Coverage 91.19% 91.34% +0.15%
==========================================
Files 80 80
Lines 5222 5222
Branches 1265 1259 -6
==========================================
+ Hits 4762 4770 +8
+ Misses 364 355 -9
- Partials 96 97 +1 ☔ View full report in Codecov by Sentry. |
rytilahti
reviewed
May 14, 2024
sdb9696
changed the title
sdb9696
force-pushed
the
feat/light_strip_effects
branch
from
42fdaf4
to
d4e9dbd
Compare
sdb9696
force-pushed
the
feat/light_strip_effects
branch
from
d4e9dbd
to
f4988b0
Compare
rytilahti
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates the attributes at device level for light, light effects, and led. i.e.
device.led,device.is_color. Will continue to support consumers using these attributes and emit a warning