SlapdObject command methods return process data #393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droideck
previously approved these changes
Nov 10, 2020
|
Something like "Make SlapdObject commands return their outputs" would fit better? |
|
Before the API is set in stone, are we sure it's the right one? Would it be better to return something like Could you also add the return value to the docstrings and documentation? |
azmeuk
force-pushed
the
slapdobject-refactor
branch
from
ce66857
to
4fce782
Compare
|
@encukou I did not know about |
azmeuk
changed the title
azmeuk
commented
Nov 15, 2020
| '{!r} process failed:\n{!r}\n{!r}'.format( | ||
| args, stdout_data, stderr_data | ||
| ) | ||
| 'Process failed: {!r}'.format(" ".join(args)) |
There was a problem hiding this comment.
I removed stdout and stderr here as they have been logged a few lines ago, and large outputs as exceptions messages are totally unpracticable.
droideck
approved these changes
Dec 24, 2020
|
I included this patch on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple refactoring, so the output of commands is usable.