test: fix integer overflow on 32-bit arches #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 32-bit arches, the `secs` value used in tst_rounding overflows:
Traceback (most recent call last):
File "/tmp/autopkgtest.pj5DKH/build.qGL/src/test/test_examples.py", line 82, in test_tmpfs
tst_rounding(mnt_dir)
File "/tmp/autopkgtest.pj5DKH/build.qGL/src/test/test_examples.py", line 355, in tst_rounding
os.utime(filename, None, ns=(atime_ns, mtime_ns))
OverflowError: timestamp out of range for platform time_t
To fix this, use the `secs` value from the very similar test_rounding
test, since it does not overflow 32-bit integers.
|
Thanks for the PR, will merge after tests! |
|
Can you check if the pyfuse3 code / tests have the same issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 32-bit arches, the
secsvalue used in tst_rounding overflows:Traceback (most recent call last):
File "/tmp/autopkgtest.pj5DKH/build.qGL/src/test/test_examples.py", line 82, in test_tmpfs
tst_rounding(mnt_dir)
File "/tmp/autopkgtest.pj5DKH/build.qGL/src/test/test_examples.py", line 355, in tst_rounding
os.utime(filename, None, ns=(atime_ns, mtime_ns))
OverflowError: timestamp out of range for platform time_t
To fix this, use the
secsvalue from the very similar test_roundingtest, since it does not overflow 32-bit integers.