Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect directive regex flags #30

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

hoefling
Copy link
Contributor

@hoefling hoefling commented Mar 20, 2023

Closes #29.

Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
@hoefling
Copy link
Contributor Author

Python 3.6 went EOL a year ago, so not sure if it is worth to be kept in the pipeline. Nevertheless, I think I can extend the CI matrix if 3.6 is still necessary.

…6 installation

Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
@krassowski
Copy link
Collaborator

If it causes problems, it's fine to drop 3.6.

Signed-off-by: oleg.hoefling <oleg.hoefling@gmail.com>
@hoefling
Copy link
Contributor Author

@krassowski it shouldn't be a problem, at least not until GH drops the ubuntu-20.04 runners 😎 I made a mistake in the previous commit, forgot to brace the single value for the os parameter in the matrix. The next run should be fine - I created a fake PR to test, looking good.

Copy link
Collaborator

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@krassowski krassowski merged commit aa851a3 into python-lsp:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple docstrings are not recognized as valid RST
2 participants