Fix fixall title suffix #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shane-XB-Qian
commented
Mar 14, 2024
|
Setting the unsafe_fixes to true will not change the behaviour of the "Fix all" action, this is actually part of the specification. I don't really have an opinion other than we would be the first to call it "Fix all (safe fixes)", but do we really need this? It is pointed out twice in the README, once in the configuration example and at the end. |
|
do we really need this?
I think yes, to me I am not the first time confused 'fix all' meaning, specifically when I chose that action, but it would may be actually do nothing (no safe fixed there actually).
…--
shane.xb.qian
|
|
"Fix all (all safe fixes)"
"Fix all (only safe fixes)"
"Fix all (safe fixes)"
you can choose one.
…--
shane.xb.qian
|
|
@jhossbach please check again if ok to you. |
|
so is it ok to merge now?
"""Optional type.
Optional[X] is equivalent to Union[X, None].
"""there is no blank line before the close
but anyway those should be not a big deal, let me know if still need something to modify, or you can help me refine it as well. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clear the 'fix all' meaning:
1, actually it is a 'term' which the 'all' meant all safe fixes only.
2, somehow some '(unsafe)' marker e.g F841 maybe would not be added, vs adding 'all safe fixes' suffix to 'fix all' probably would be a more direct meaning title.