Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter and tests are failing on due to new "consider-using-with" #19

Closed
krassowski opened this issue Apr 25, 2021 · 1 comment · Fixed by #20
Closed

Linter and tests are failing on due to new "consider-using-with" #19

krassowski opened this issue Apr 25, 2021 · 1 comment · Fixed by #20
Milestone
v1.1.0

Comments

@krassowski
Copy link
Contributor

Yesterday's release of Pylint 2.8 added consider-using-with among other new checkers. The tests are currently failing on master in six places and I will try to fix them by refactoring to use the with statement if possible, or adding # pylint: disable=consider-using-with otherwise.
@ccordoba12
Copy link
Member

Thanks for giving us a hand with that @krassowski!

@ccordoba12 ccordoba12 added this to the v1.1.0 milestone Apr 25, 2021
@krassowski krassowski mentioned this issue Apr 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

PR: Address pylint's "consider-using-with" warnings krassowski/python-lsp-server
2 participants
@ccordoba12 @krassowski