Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer info log message for missing optional modules #266

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Prefer info log message for missing optional modules #266

merged 1 commit into from
Sep 13, 2022

Conversation

doolio
Copy link
Contributor

@doolio doolio commented Sep 13, 2022

Some modules are optional and therefore may not be installed by the user. Log such events for information rather than a warning to the user.

Resolves #265.

Some modules are optional and therefore may not be installed by the
user.  Log such events for information rather than a warning to the
user.

Resolves #265.
@ccordoba12 ccordoba12 added this to the v1.6.0 milestone Sep 13, 2022
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @doolio!

@ccordoba12 ccordoba12 changed the title Prefer INFO log message for missing optional modules (#265) Prefer info log message for missing optional modules (#265) Sep 13, 2022
@ccordoba12 ccordoba12 changed the title Prefer info log message for missing optional modules (#265) Prefer info log message for missing optional modules Sep 13, 2022
@ccordoba12 ccordoba12 merged commit b218215 into python-lsp:develop Sep 13, 2022
@doolio doolio deleted the msg-warn-to-info branch September 14, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server warns when optional modules do not exist
2 participants