Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty cwd value for pylint #371

Merged
merged 2 commits into from
May 15, 2023
Merged

Fix empty cwd value for pylint #371

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
166b5f6
Fix empty cwd value for pylint
Ultimator14 Apr 25, 2023
df13cf3
Fix linting issues
ccordoba12 May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pylsp/plugins/pylint_lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class PylintLinter:
last_diags = collections.defaultdict(list)

@classmethod
def lint(cls, document, is_saved, flags=''):
def lint(cls, document, is_saved, flags=''): # pylint: disable=too-many-locals,too-many-branches
"""Plugin interface to pylsp linter.

Args:
Expand Down Expand Up @@ -95,8 +95,12 @@ def lint(cls, document, is_saved, flags=''):
] + (shlex.split(str(flags)) if flags else [])
log.debug("Calling pylint with '%s'", ' '.join(cmd))

cwd = document._workspace.root_path
if not cwd:
cwd = os.path.dirname(__file__)

with Popen(cmd, stdout=PIPE, stderr=PIPE,
cwd=document._workspace.root_path, universal_newlines=True) as process:
cwd=cwd, universal_newlines=True) as process:
process.wait()
json_out = process.stdout.read()
err = process.stderr.read()
Expand Down
Loading