Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point to a more up to date isort plugin in README #483

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Point to a more up to date isort plugin in README #483

merged 1 commit into from
Nov 8, 2023

Conversation

doolio
Copy link
Contributor

@doolio doolio commented Nov 7, 2023 •
edited by ccordoba12
Loading

This plugin complies with pylsp's configuration conventions.

Fixes #478

@doolio
Point to a different isort plugin in README
7cd6911 
This plugin complies with pylsp's configuration conventions.

Resolves: python-lsp#478
@doolio
Copy link
Contributor Author

doolio commented Nov 8, 2023

@ccordoba12 I think it would be worthwhile to reach out to @chantera about moving their plugin to the pylsp org.

@ccordoba12 ccordoba12 added this to the v1.9.1 milestone Nov 8, 2023
@ccordoba12 ccordoba12 added the task label Nov 8, 2023
@ccordoba12 ccordoba12 changed the title Point to a different isort plugin in README Point to a more up to date isort plugin in README Nov 8, 2023
ccordoba12
ccordoba12 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @doolio!

@ccordoba12
Copy link
Member

I think it would be worthwhile to reach out to @chantera about moving their plugin to the pylsp org.

Good idea! @chantera, let me know if you'd like to host your plugin in our organization to grant you the appropriate permissions to do it.

@ccordoba12 ccordoba12 merged commit 3525e8b into python-lsp:develop Nov 8, 2023
10 checks passed
@doolio doolio deleted the point-to-different-isort-plugin branch January 19, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.

Considering pointing to python-lsp-isort rather than pyls-isort in the README
2 participants
@doolio @ccordoba12