Add support for notebook document completions #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ccordoba12 can you TAL at this PR? :) |
|
Thanks for the ping @tkrabel! Will do right away. |
ccordoba12
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
As you said @smacke, this is pretty straightforward, so it looks good to me.
|
Awesome TY! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we add support for notebook document completions, so that completions can work across cell boundaries. The implementation is straightforward and closely follows that for definitions.
Test plan: added a unit test that fails without the changes in this PR and passes with the changes.