Fix path completion when client doesn't support code snippets #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
changed the title
ccordoba12
reviewed
Dec 7, 2023
There was a problem hiding this comment.
Thanks @i-aki-y for your contribution! Please run black in test_completion.py to fix the error reported by our code analysis workflow.
The rest looks good to me.
|
@ccordoba12 Thank you for your review. I applied |
ccordoba12
reviewed
Dec 10, 2023
There was a problem hiding this comment.
@i-aki-y, one last, tiny suggestion for you then this should be ready.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
|
@ccordoba12 Thanks. I applied your suggestion! |
ccordoba12
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to fix #373.
I fixed to escape
os.seponly when a client support snippet, based on discussion in the above issue.I would appreciate it if you could review this PR.