Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a way to standarize the configuration file #75

Closed
alexppg opened this issue Dec 10, 2019 · 1 comment · Fixed by #78
Closed

Find a way to standarize the configuration file #75

alexppg opened this issue Dec 10, 2019 · 1 comment · Fixed by #78
Assignees
Labels
help wanted Extra attention is needed Improvement Not a bug but... could be better

Comments

@alexppg
Copy link
Member

alexppg commented Dec 10, 2019

Is your feature request related to a problem? Please describe.
The configuration file has some quirks. With the given example:

my-minimal-microservice:
  APP_NAME: "Python Microservice"
  environment: "I'm running in a local machine"
pyms:
  requests:
    data: ""
  metrics: true
  • The APP_NAME and the my-minimal-microservice are redundant
  • APP_NAME is expected to be in capital letters, but others don't.

Describe the solution you'd like
Something like:

config:
  app_name: "Python Microservice"
  environment: "I'm running in a local machine"
pyms:
  requests:
    data: ""
  metrics: true

There should something that converts the app_name to an usable name, changing spaces by slashes or something like that.

Also, if using capital letters for keys of the configuration makes sense, it should be established somewhere which ones are and why.

Describe alternatives you've considered
NaN

Additional context
NaN

@alexppg alexppg added help wanted Extra attention is needed Improvement Not a bug but... could be better labels Dec 10, 2019
@avara1986 avara1986 self-assigned this Dec 13, 2019
avara1986 added a commit that referenced this issue Dec 15, 2019
* Refactor config

* Fix flake8

* Disabled services with key "enabled" without remove code block

* Fix pylint error
@alexppg
Copy link
Member Author

alexppg commented Dec 21, 2019

Ya está hecho, así que cierro x)

@alexppg alexppg closed this as completed Dec 21, 2019
@avara1986 avara1986 linked a pull request Mar 30, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Improvement Not a bug but... could be better
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants