Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PyPy3.8 #256

Merged
merged 1 commit into from Feb 21, 2022
Merged

Added PyPy3.8 #256

merged 1 commit into from Feb 21, 2022

Conversation

radarhere
Copy link
Member

Added PyPy 3.8. I'm avoiding PyPy 3.9 for now, as it is in "beta".

This PR also updates to 7.3.8.

@hugovk hugovk added the automerge Automatically merge PRs that are ready label Feb 21, 2022
@radarhere radarhere merged commit c4f4c04 into python-pillow:main Feb 21, 2022
@radarhere radarhere deleted the pypy branch February 21, 2022 09:16
@nulano
Copy link
Contributor

nulano commented Mar 20, 2022

This PR also updates to 7.3.8.

From pypy-dev mailing list (emphasis mine):

Once again, I broke ABI compatibility with the new release. I re-added
a field to PyDateTime_CAPI that should have been part of the original
PyPy3.7 release, but was missed, and so should be left out of PyPy3.7
v7.3.x. This causes segfaults when using PyPy3.7-v7.3.8 on wheels
built for PyPy3.7-v7.3.7 and older. Please do not build packages with
PyPy3.7-v7.3.8 for general release because they will not work on older
PyPy3.7.

What is doubly annoying is this is exactly why I needed to release
v7.3.7 over v7.3.6. PRs welcome to suggest a test for this. A "hg
diff" is a start, but it picks up refactoring and valid additions as
well, so it needs to be a bit smarter. Maybe something with CFFI?

Matti

@radarhere
Copy link
Member Author

Thanks for the info.

Given that there was previous plan to release PyPy 7.3.9 almost a week ago,

https://libera.irclog.whitequark.org/pypy/2022-03-07

it seems we should release 7.3.9 by March 14 to match CPython

I'm going to hold out hope that 7.3.9 will be released before April 1, so that we don't have to downgrade it for Pillow 9.1.0. Something to keep an eye on.

@radarhere radarhere mentioned this pull request Mar 20, 2022
Closed
20 tasks
@hugovk
Copy link
Member

hugovk commented Mar 20, 2022

https://libera.irclog.whitequark.org/pypy/search?q=7.3.9

Later 2022-03-09 messages say:

09:22 so it turns out we do not need a 7.3.9 for ABI compatibility,
09:22 PyO3 will reject 7.3.7 and earlier on py3.7 to work around the problem
09:23 we should still do a new release to build with pyexpat 2.4,7, bzip2 1.0.8, and sqlite 3.38
09:26 maybe it should be 7.3.8.final.1 ? Have we ever done a release with serial != 0?

Yesterday:

18:26 the 7.3.9 release is blocked by issue 3706: we need to refactor our headers to work with -Wstrict-aliasing

The release blocker: https://foss.heptapod.net/pypy/pypy/-/issues/3706

@radarhere radarhere mentioned this pull request Mar 23, 2022
Closed
@hugovk
Copy link
Member

hugovk commented Mar 24, 2022

https://foss.heptapod.net/pypy/pypy/-/issues/3706 has been fixed.

@radarhere
Copy link
Member Author

PyPy 7.3.9 has now been merged in, with #272

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge PRs that are ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@radarhere @nulano @hugovk