Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ciso8601 in Pnnotdb 0.4.7 #47

Closed
potiuk opened this issue Sep 27, 2022 · 0 comments · Fixed by #48
Closed

Missing ciso8601 in Pnnotdb 0.4.7 #47

potiuk opened this issue Sep 27, 2022 · 0 comments · Fixed by #48

Comments

@potiuk
Copy link

potiuk commented Sep 27, 2022

Airflow canary builds started to fail after last pintodb release:

Example here:
https://github.com/apache/airflow/actions/runs/3133775825/jobs/5087788714#step:10:9254

Seems that the recent release has a hidden dependency on ciso8601 package, but it missing in install_requires.

  ______ ERROR collecting tests/providers/apache/pinot/hooks/test_pinot.py _______
  ImportError while importing test module '/opt/airflow/tests/providers/apache/pinot/hooks/test_pinot.py'.
  Hint: make sure your test modules/packages have valid Python names.
  Traceback:
  /usr/local/lib/python3.8/importlib/__init__.py:127: in import_module
      return _bootstrap._gcd_import(name[level:], package, level)
  tests/providers/apache/pinot/hooks/test_pinot.py:29: in <module>
      from airflow.providers.apache.pinot.hooks.pinot import PinotAdminHook, PinotDbApiHook
  airflow/providers/apache/pinot/hooks/pinot.py:24: in <module>
      from pinotdb import connect
  /usr/local/lib/python3.8/site-packages/pinotdb/__init__.py:1: in <module>
      from pinotdb.db import connect, connect_async
  /usr/local/lib/python3.8/site-packages/pinotdb/db.py:2: in <module>
      import ciso8601
  E   ModuleNotFoundError: No module named 'ciso8601'
potiuk added a commit to potiuk/airflow that referenced this issue Sep 27, 2022
Our canary builds detected that PinotDB released 7 hours ago lacks
ciso8601 dependency, which make import fail during test collection.

This PR adds the dependency in provider until the issue is fixed.
PR has been raised to PinotDB

python-pinot-dbapi/pinot-dbapi#47
potiuk added a commit to apache/airflow that referenced this issue Sep 27, 2022
Our canary builds detected that PinotDB released 7 hours ago lacks
ciso8601 dependency, which make import fail during test collection.

This PR adds the dependency in provider until the issue is fixed.
PR has been raised to PinotDB

python-pinot-dbapi/pinot-dbapi#47
jedcunningham pushed a commit to apache/airflow that referenced this issue Sep 27, 2022
Our canary builds detected that PinotDB released 7 hours ago lacks
ciso8601 dependency, which make import fail during test collection.

This PR adds the dependency in provider until the issue is fixed.
PR has been raised to PinotDB

python-pinot-dbapi/pinot-dbapi#47
(cherry picked from commit 5ff0bc6)
eladkal added a commit to eladkal/airflow that referenced this issue Oct 23, 2022
Issue python-pinot-dbapi/pinot-dbapi#47 is resolved and released in 0.4.8 thus we can bump the package version
eladkal added a commit to apache/airflow that referenced this issue Oct 24, 2022
Issue python-pinot-dbapi/pinot-dbapi#47 is resolved and released in 0.4.8 thus we can bump the package version
a0x8o added a commit to a0x8o/airflow that referenced this issue Oct 24, 2022
Issue python-pinot-dbapi/pinot-dbapi#47 is resolved and released in 0.4.8 thus we can bump the package version
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jan 30, 2023
Our canary builds detected that PinotDB released 7 hours ago lacks
ciso8601 dependency, which make import fail during test collection.

This PR adds the dependency in provider until the issue is fixed.
PR has been raised to PinotDB

python-pinot-dbapi/pinot-dbapi#47
(cherry picked from commit 5ff0bc69a5cf09122a91b5e28e72f1a58d443f03)

GitOrigin-RevId: 5d0d3801bc25e72ad7d438773d907bdf2a0ddef4
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Mar 30, 2023
Our canary builds detected that PinotDB released 7 hours ago lacks
ciso8601 dependency, which make import fail during test collection.

This PR adds the dependency in provider until the issue is fixed.
PR has been raised to PinotDB

python-pinot-dbapi/pinot-dbapi#47

GitOrigin-RevId: 5ff0bc69a5cf09122a91b5e28e72f1a58d443f03
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Mar 30, 2023
Issue python-pinot-dbapi/pinot-dbapi#47 is resolved and released in 0.4.8 thus we can bump the package version

GitOrigin-RevId: 36b921741531612637cb244e938cd0bd1cad74a8
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Apr 4, 2023
Our canary builds detected that PinotDB released 7 hours ago lacks
ciso8601 dependency, which make import fail during test collection.

This PR adds the dependency in provider until the issue is fixed.
PR has been raised to PinotDB

python-pinot-dbapi/pinot-dbapi#47

GitOrigin-RevId: 5ff0bc69a5cf09122a91b5e28e72f1a58d443f03
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Apr 4, 2023
Issue python-pinot-dbapi/pinot-dbapi#47 is resolved and released in 0.4.8 thus we can bump the package version

GitOrigin-RevId: 36b921741531612637cb244e938cd0bd1cad74a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant