Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI | Update black version in pre-commit #137

Merged
merged 5 commits into from
May 27, 2022
Merged

Fix CI | Update black version in pre-commit #137

merged 5 commits into from
May 27, 2022

Conversation

Bobronium
Copy link
Contributor

This fixes CI failure caused by pallets/click#2225

@Bobronium Bobronium changed the title Update black version in pre-commit Fix CI | Update black version in pre-commit May 22, 2022
@Bobronium Bobronium mentioned this pull request May 22, 2022
Merged
branchvincent
branchvincent requested changes May 27, 2022
View reviewed changes
Copy link
Member

@branchvincent branchvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Bobronium, do you mind pushing black's changes as well so checks can pass?

@Bobronium
Update black and python version
2fba546 
Python version is updated to satisfy black constraint

The current project's Python requirement (>=3.6,<4.0) is not compatible with some of the required packages Python requirement:
    - black requires Python >=3.6.2, so it will not be satisfied for Python >=3.6,<3.6.2
@Bobronium
Reformat files with black 22.3.0
2d0064b
@Bobronium
Copy link
Contributor Author

@branchvincent, done!

Had to update python minor version as well.

@Bobronium
Copy link
Contributor Author

Bobronium commented May 27, 2022 •
edited

I guess CI hasn't been working for a while. poetry installation fails, as well as python 3.6 on macOS.

Can say right away that poetry installed witth legacy install-poetry script, as for python — I have no idea :)

Turns out, I confused install-poetry.py with get-poetry.py

Bobronium and others added 2 commits May 28, 2022 00:04
@Bobronium @branchvincent
Remove black from pyproject.toml
be5f1c9 
Co-authored-by: Branch Vincent <branchevincent@gmail.com>
@Bobronium
Revert updating python version
6b9aaaa
@branchvincent
Copy link
Member

tests fail since the latest pre-release of poetry dropped 3.6 support, we could pin to --version=1.2.0a2 but even that just uncovers more issues with 3.6 support: https://github.com/branchvincent/cleo/runs/6631287709?check_suite_focus=true

I can handle those issues in another PR, getting linting to pass here is more than sufficient

branchvincent
branchvincent approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@branchvincent branchvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@branchvincent branchvincent merged commit e103e1c into python-poetry:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@branchvincent branchvincent branchvincent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bobronium @branchvincent