Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more ruff rules #406

Merged
merged 4 commits into from
Feb 25, 2024
Merged

Add more ruff rules #406

merged 4 commits into from
Feb 25, 2024

Conversation

Secrus
Copy link
Member

@Secrus Secrus commented Feb 25, 2024 •
edited
Loading

Some more rules from Ruff that I found interesting/useful.

@Secrus Secrus added the skip news Skip the check for a news file label Feb 25, 2024
@Secrus Secrus requested review from bswck, trag1c and a team and removed request for bswck and trag1c February 25, 2024 18:51
trag1c
trag1c requested changes Feb 25, 2024
View reviewed changes
src/cleo/descriptors/text_descriptor.py Show resolved Hide resolved
src/cleo/io/outputs/section_output.py Outdated Show resolved Hide resolved
tests/ui/exception_trace/test_frame.py Outdated Show resolved Hide resolved
@Secrus Secrus requested a review from trag1c February 25, 2024 19:05
trag1c
trag1c previously approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@trag1c trag1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more suggestion, otherwise LGTM 👍

tests/commands/completion/test_completions_command.py Outdated Show resolved Hide resolved
@Secrus Secrus merged commit 730aea8 into python-poetry:main Feb 25, 2024
17 checks passed
@Secrus Secrus deleted the more-ruff-rules branch February 25, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trag1c trag1c trag1c approved these changes

Assignees
No one assigned
Labels
skip news Skip the check for a news file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Secrus @trag1c