Improve support for PEP-440 direct references #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abn
force-pushed
the
file-uri-scheme
branch
3 times, most recently
from
2313b1b
to
1687fb9
Compare
abn
force-pushed
the
file-uri-scheme
branch
7 times, most recently
from
145d9a2
to
28a02ba
Compare
With this change we allow for PEP-508 string for file dependencies to use PEP-440 direct reference using the file URI scheme (RFC-8089). Note that this implementation will not allow non RFC-8089 file path references. In order to allow for sdist to be portable in sane use cases, we ensure that relative path dependencies do not use the file URI scheme, but preserve path if relative or directories. In addition to file resource, directory dependencies now support the same scheme. References: - https://www.python.org/dev/peps/pep-0508/#backwards-compatibility - https://www.python.org/dev/peps/pep-0440/#direct-references - https://tools.ietf.org/html/rfc8089 - https://discuss.python.org/t/what-is-the-correct-interpretation-of-path-based-pep-508-uri-reference/2815/11
This was referenced Apr 16, 2020
kasteph
reviewed
Apr 21, 2020
kasteph
approved these changes
Apr 21, 2020
Merged
Closed
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we allow for PEP-508 string for file dependencies
to use PEP-440 direct reference using the file URI scheme (RFC-8089).
Note that this implementation will not allow non RFC-8089 file path
references. In order to allow for sdist to be portable in sane use
cases, we ensure that relative path dependencies do not use the
file URI scheme, but preserve path if relative or directories.
In addition to file resource, directory dependencies now support
the same scheme.
References: