Refactor: unify package inspection logic #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Builds are failing due to #2302 |
abn
force-pushed
the
refactor/inspection
branch
5 times, most recently
from
262d313
to
14f92d9
Compare
kasteph
reviewed
Apr 17, 2020
abn
force-pushed
the
refactor/inspection
branch
from
14f92d9
to
ee28932
Compare
|
@sdispater i have ensured that we only execute |
abn
force-pushed
the
refactor/inspection
branch
4 times, most recently
from
cf78dfd
to
692f37b
Compare
abn
force-pushed
the
refactor/inspection
branch
from
692f37b
to
20a8346
Compare
abn
force-pushed
the
refactor/inspection
branch
from
20a8346
to
c019bf7
Compare
abn
requested review from
a team and
kasteph
and removed request for
sdispater and
kasteph
kasteph
reviewed
Apr 25, 2020
This change brings together logic repeated in various places to discover package information.
Moving to tox to use isolated buids to avoid some environment specific dragons in relation to `poetry install` command. Today, the symlinks will cause issues when poetry attempts to add an editable install into the venv due to a pathlib2 bug.
abn
force-pushed
the
refactor/inspection
branch
from
c019bf7
to
079087e
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings together logic repeated in various places to discover package information. As a side-effect of this various edge cases have been improved and we shouldhave one place to change the code for package inspection related logic.
In addition to the above, this alos cleans up some test code and also unify call of urlparse and download.
Note this requires python-poetry/poetry-core#22. In order for the builds to work, I have created a branch for core that works around a few non issues with the current poetry releases used in ci. Additionally, the FreeBSD tests are failing because of a symbolic link issue (unrelated),
Pull Request Check List
Updated documentation for changed code.