Skip to content

Commit

Permalink
Remove hash function from 'FileDependency'
Browse files Browse the repository at this point in the history
This also removes the tests for the hash function.
  • Loading branch information
dunkmann00 committed Nov 30, 2022
1 parent d98aa6e commit 34e0e48
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 74 deletions.
11 changes: 0 additions & 11 deletions src/poetry/core/packages/file_dependency.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
from __future__ import annotations

import hashlib
import io

from pathlib import Path
from typing import Iterable

Expand Down Expand Up @@ -62,14 +59,6 @@ def full_path(self) -> Path:
def is_file(self) -> bool:
return True

def hash(self, hash_name: str = "sha256") -> str:
h = hashlib.new(hash_name)
with self._full_path.open("rb") as fp:
for content in iter(lambda: fp.read(io.DEFAULT_BUFFER_SIZE), b""):
h.update(content)

return h.hexdigest()

@property
def base_pep_508_name(self) -> str:
requirement = self.pretty_name
Expand Down
63 changes: 0 additions & 63 deletions tests/packages/test_file_dependency.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,69 +30,6 @@ def test_file_dependency_dir() -> None:
FileDependency("demo", DIST_PATH)


def test_default_hash() -> None:
path = DIST_PATH / TEST_FILE
dep = FileDependency("demo", path)
sha_256 = "72e8531e49038c5f9c4a837b088bfcb8011f4a9f76335c8f0654df6ac539b3d6"
assert dep.hash() == sha_256


try:
from hashlib import algorithms_guaranteed
except ImportError:
algorithms_guaranteed = {"md5", "sha1", "sha224", "sha256", "sha384", "sha512"}


@pytest.mark.parametrize(
"hash_name,expected",
[
(hash_name, value)
for hash_name, value in [
("sha224", "972d02f36539a98599aed0566bc8aaf3e6701f4e895dd797d8f5248e"),
(
"sha3_512",
"c04ee109ae52d6440445e24dbd6d244a1d0f0289ef79cb7ba9bc3c139c0237169af9a8f61cd1cf4fc17f853ddf84f97c475ac5bb6c91a4aff0b825b884d4896c",
),
(
"blake2s",
"c336ecbc9d867c9d860accfba4c3723c51c4b5c47a1e0a955e1c8df499e36741",
),
(
"sha3_384",
"d4abb2459941369aabf8880c5287b7eeb80678e14f13c71b9ecf64c772029dc3f93939590bea9ecdb51a1d1a74fefc5a",
),
(
"blake2b",
"48e70abac547ab38e2330e6e6743a0c0f6274dcaa6df2c98135a78a9dd5b04a072d551fc3851b34da03eb0bf50dd71c7f32a8c36956e99fd6c66491bc7844800",
),
(
"sha256",
"72e8531e49038c5f9c4a837b088bfcb8011f4a9f76335c8f0654df6ac539b3d6",
),
(
"sha512",
"e08a00a4b86358e49a318e7e3ba7a3d2fabdd17a2fef95559a0af681ea07ab1296b0b8e11e645297da296290661dc07ae3c8f74eab66bd18a80dce0c0ccb355b",
),
(
"sha384",
"aa3144e28c6700a83247e8ec8711af5d3f5f75997990d48ec41e66bd275b3d0e19ee6f2fe525a358f874aa717afd06a9",
),
("sha3_224", "64bfc6e4125b4c6d67fd88ad1c7d1b5c4dc11a1970e433cd576c91d4"),
("sha1", "4c057579005ac3e68e951a11ffdc4b27c6ae16af"),
(
"sha3_256",
"ba3d2a964b0680b6dc9565a03952e29c294c785d5a2307d3e2d785d73b75ed7e",
),
]
if hash_name in algorithms_guaranteed
],
)
def test_guaranteed_hash(hash_name: str, expected: str) -> None:
path = DIST_PATH / TEST_FILE
dep = FileDependency("demo", path)
assert dep.hash(hash_name) == expected


def _test_file_dependency_pep_508(
mocker: MockerFixture,
name: str,
Expand Down

0 comments on commit 34e0e48

Please sign in to comment.