mark path case sensitive tests as xfail for win32

python-poetry · Apr 16, 2020 · a7fdee6 · a7fdee6
1 parent 1fac3b7
commit a7fdee6
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 7 deletions.
diff --git a/poetry/core/utils/_compat.py b/poetry/core/utils/_compat.py
@@ -20,6 +20,7 @@
 PY34 = sys.version_info >= (3, 4)
 PY35 = sys.version_info >= (3, 5)
 PY36 = sys.version_info >= (3, 6)
+PY37 = sys.version_info >= (3, 7)
 
 WINDOWS = sys.platform == "win32"
 

diff --git a/tests/masonry/builders/test_builder.py b/tests/masonry/builders/test_builder.py
@@ -1,8 +1,13 @@
 # -*- coding: utf-8 -*-
+import sys
+
 from email.parser import Parser
 
+import pytest
+
 from poetry.core.factory import Factory
 from poetry.core.masonry.builders.builder import Builder
+from poetry.core.utils._compat import PY37
 from poetry.core.utils._compat import Path
 
 
@@ -11,20 +16,24 @@ def test_builder_find_excluded_files(mocker):
     p.return_value = []
 
     builder = Builder(
-        Factory().create_poetry(Path(__file__).parent / "fixtures" / "complete"),
+        Factory().create_poetry(Path(__file__).parent / "fixtures" / "complete")
     )
 
     assert builder.find_excluded_files() == {"my_package/sub_pkg1/extra_file.xml"}
 
 
+@pytest.mark.xfail(
+    sys.platform == "win32" and not PY37,
+    reason="Windows is case insensitive for the most part",
+)
 def test_builder_find_case_sensitive_excluded_files(mocker):
     p = mocker.patch("poetry.core.vcs.git.Git.get_ignored_files")
     p.return_value = []
 
     builder = Builder(
         Factory().create_poetry(
             Path(__file__).parent / "fixtures" / "case_sensitive_exclusions"
-        ),
+        )
     )
 
     assert builder.find_excluded_files() == {
@@ -38,22 +47,26 @@ def test_builder_find_case_sensitive_excluded_files(mocker):
     }
 
 
+@pytest.mark.xfail(
+    sys.platform == "win32" and not PY37,
+    reason="Windows is case insensitive for the most part",
+)
 def test_builder_find_invalid_case_sensitive_excluded_files(mocker):
     p = mocker.patch("poetry.core.vcs.git.Git.get_ignored_files")
     p.return_value = []
 
     builder = Builder(
         Factory().create_poetry(
             Path(__file__).parent / "fixtures" / "invalid_case_sensitive_exclusions"
-        ),
+        )
     )
 
     assert {"my_package/Bar/foo/bar/Foo.py"} == builder.find_excluded_files()
 
 
 def test_get_metadata_content():
     builder = Builder(
-        Factory().create_poetry(Path(__file__).parent / "fixtures" / "complete"),
+        Factory().create_poetry(Path(__file__).parent / "fixtures" / "complete")
     )
 
     metadata = builder.get_metadata_content()
@@ -103,7 +116,7 @@ def test_get_metadata_content():
 
 def test_metadata_homepage_default():
     builder = Builder(
-        Factory().create_poetry(Path(__file__).parent / "fixtures" / "simple_version"),
+        Factory().create_poetry(Path(__file__).parent / "fixtures" / "simple_version")
     )
 
     metadata = Parser().parsestr(builder.get_metadata_content())
@@ -115,7 +128,7 @@ def test_metadata_with_vcs_dependencies():
     builder = Builder(
         Factory().create_poetry(
             Path(__file__).parent / "fixtures" / "with_vcs_dependency"
-        ),
+        )
     )
 
     metadata = Parser().parsestr(builder.get_metadata_content())
@@ -129,7 +142,7 @@ def test_metadata_with_url_dependencies():
     builder = Builder(
         Factory().create_poetry(
             Path(__file__).parent / "fixtures" / "with_url_dependency"
-        ),
+        )
     )
 
     metadata = Parser().parsestr(builder.get_metadata_content())