Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packaging dep to v20.8 #125

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Conversation

gi0baro
Copy link
Contributor

@gi0baro gi0baro commented Jan 18, 2021

Resolves: python-poetry/poetry#3458

  • Added tests for changed code.
  • Updated documentation for changed code.

@damienrj
Copy link

This should also resolve issue python-poetry/poetry#3591 now that I understand the problem better.

@alexifm
Copy link

alexifm commented Jan 22, 2021

Based on the testing over at python-poetry/poetry#3530, this PR does the trick.

@alexifm
Copy link

alexifm commented Jan 22, 2021

@finswimmer Could you review this?

@@ -23,5 +23,6 @@ python = "^3.6"

jsonschema = "^3.2.0"
lark-parser = "^0.9.0"
packaging = "^20.1"
packaging = "^20.8"
pyrsistent = "^0.16.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is pyrsistent added explicitly here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdispater 'cause in ^0.17 they dropped Python 2.x support (ref: https://github.com/tobgu/pyrsistent/blob/master/CHANGES.txt#L17#L19)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gi0baro Thanks for the information 👍

@sdispater sdispater merged commit b5a1b1f into python-poetry:master Jan 29, 2021
@henryiii
Copy link
Contributor

Hoping that Packaging 20.9 will be released soon (maybe today!) and that will also add support for Universal wheels on Apple Silicon, so it would be a fantastic upgrade (okay, not quite as important yet as loading any wheel on Intel Big Sur, which was the core of this update, but still and important step forward too!). pypa/packaging#385

@alexifm
Copy link

alexifm commented Jan 29, 2021

Thanks @sdispater!

@henryiii
Copy link
Contributor

Packaging 20.9 is out, can we get an update? It's needed for proper Apple Silicon support.

@damienrj
Copy link

damienrj commented Feb 4, 2021

Any updates on a release? I had just switched my team to poetry before this started and hasn't been a great experience for everyone so we are looking forward to the release.

@henryiii
Copy link
Contributor

henryiii commented Feb 4, 2021

I'd love to see an update too; not being able to install NumPy on macOS Big Sur is a quite a bummer! I asked for Packaging 20.9 largely so it would be possible to be included in the Poetry 1.1.x series, since 21.0 will drop Python 2.7 and 3.5 (perfect for Poetry 1.2).

@matteosantama
Copy link

Looking forward to a release as well, as I'm sure are lots of other Big Sure users out there :)

@ghost
Copy link

ghost commented Feb 5, 2021

Hi @sdispater I would really appreciate if this could be released or are there any reasons not to do so?

@sdispater sdispater mentioned this pull request Feb 5, 2021
@damienrj
Copy link

Has this fixed the problem for others? I still can't install packages
python-poetry/poetry#3591 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants