Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pep440: support upper bound post/local release comparisons #157

Merged
merged 3 commits into from
Apr 2, 2021
Merged

pep440: support upper bound post/local release comparisons #157

merged 3 commits into from
Apr 2, 2021

Commits on Apr 2, 2021

  1. tests: add coverage for poetry.core.version.pep440

    @abn
    abn committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    dd32e58 View commit details
    Browse the repository at this point in the history

  2. pep440: allow release tuples

    @abn
    abn committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    bdf6080 View commit details
    Browse the repository at this point in the history

  3. pep440: support post/local release comparisons 

    This change ensures that post and local releases are taken into
consideration when checking if version range allows a post release
local build release at upper and lower bounds.

The following conditions now hold for upper bound checks.

- `<=3.0.0` allows `3.0.0+local.1`, `3.0.0-1`
- `<=3.0.0+local.1` disallows `3.0.0+local.2`, allows `3.0.0-1`
- `<=3.0.0-1` allows `3.0.0+local.1`, `3.0.0`

Lower bound checks require no modification and works due to the
implicit version comparison of `poetry.core.pep440.PEP440Version`.
    @abn
    abn committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    bf2785e View commit details
    Browse the repository at this point in the history