Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: clean up default test workflow #20

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

abn
Copy link
Member

@abn abn commented Apr 9, 2020

This is a cleanup of the current github actions workflows to remove duplicate code.

@abn abn force-pushed the github-actions branch 2 times, most recently from 9927c3a to bbdde21 Compare April 9, 2020 16:50
@abn abn marked this pull request as ready for review April 9, 2020 16:51
@abn abn requested a review from a team April 9, 2020 16:51
.github/workflows/tests.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@abn abn force-pushed the github-actions branch 2 times, most recently from 7dc362c to 188e061 Compare April 10, 2020 18:29
@abn abn requested a review from sdispater April 10, 2020 18:29
@abn
Copy link
Member Author

abn commented Apr 10, 2020

@sdispater I think we can discuss the use of pip vs get-poetry outside of this, I have maintained the used of the installer for now. Also added a cache check step to prevent any issues with corrupt caches.

@abn
Copy link
Member Author

abn commented Apr 10, 2020

The same changes have been also added for poetry.

See: python-poetry/poetry#2289

@abn abn force-pushed the github-actions branch 4 times, most recently from 4951326 to 31144bf Compare April 12, 2020 21:39
@sdispater sdispater merged commit d3ee954 into python-poetry:master Apr 14, 2020
@abn abn deleted the github-actions branch April 15, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants