Support most of the guaranteed hashes #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works toward resolution of python-poetry/poetry#4523 - [X] Added tests for changed code - [X] Added documentation for changed code Documentation is at least equivalent to the existing stuff. - Implement most of the "guaranteed" hashes as per PEP 503 - Leave out shake, because they're variable length - Feel it's unlikely anyone's repo manager is using these
|
@sdispater python-poetry/poetry#4523 introduces some pretty critical breakage for anyone using private package repositories, and in a situation where version pins are not common (pinning a subdependency of a build tool). Do you or another maintainer have the bandwidth to review this and aim for a 1.0.6 release ASAP? |
|
@awilkins Thanks for the PR! You will need to fix the linting issues before I can merge this. Also, it seems that some of the hash types are not available on Python 2.7 and 3.5. |
sdispater
approved these changes
Sep 20, 2021
3 tasks
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works toward resolution of python-poetry/poetry#4523
Also needs client changes
Documentation is at least equivalent to the existing stuff.
No offence to @hydra-zim who has produced pretty much the same PR @ #206 : this one has tests, and also targets the current mainline release branch instead of the future. The future is great, I would prefer this was fixed sooner.