Fix stub-only partial namespace packages not recognized as packages #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neersighted
previously approved these changes
Jan 25, 2022
Merged
|
@henribru can you rebase this please? |
henribru
force-pushed
the
fix-stub-only-partial-namespace-packages
branch
from
49f853e
to
6bbcde5
Compare
|
Done! |
henribru
changed the title
henribru
changed the title
abn
reviewed
May 6, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
neersighted
approved these changes
May 7, 2022
Merged
julienmalard
added a commit
to julienmalard/poetry-core
that referenced
this pull request
Aug 22, 2022
This fixes python-poetry#221 by exchanging the regex package for re (the former having fixed the long-standing bug in re (see [here](lark-parser/lark#590) for details). Not sure if this will work for poetry (i.e., whether adding regex as a dependency is acceptable)...but thought I would propose this change and wait for feedback to take it from there. Thanks!
bostonrwalker
pushed a commit
to bostonrwalker/poetry-core
that referenced
this pull request
Aug 29, 2022
DavidVujic
pushed a commit
to DavidVujic/poetry-core
that referenced
this pull request
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry/poetry#4621
The tests are based on the existing tests for stub-only packages introduced in python-poetry/poetry#2000