Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint and fix pep8 naming conventions #247

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danieleades
Copy link
Contributor

i'll see what the CI does, but i'm expecting there's a reasonable chance this is a breaking change for downstream

@neersighted
Copy link
Member

This will probably cause some breakage, yeah. It's a bigger codebase, but I think this would be good to try in poetry itself first since it has no consumers outside of plugins (and the plugin API is not yet stable).

See python-poetry/poetry#4776.

@danieleades
Copy link
Contributor Author

This will probably cause some breakage, yeah. It's a bigger codebase, but I think this would be good to try in poetry itself first since it has no consumers outside of plugins (and the plugin API is not yet stable).

See python-poetry/poetry#4776.

downstream tests passed. wasn't expecting that

@danieleades
Copy link
Contributor Author

grepping the code, it's clear that the Exception class is used downstream. I guess the 'downstream' test case doesn't cover it.

I guess both repos will need to be changed together, and it's a major version bump for core

@danieleades
Copy link
Contributor Author

rebased

@finswimmer
Copy link
Member

We could ignore the N818 error for now, to introduce pep-naming anyway.

@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants