Use flake8-simplify #267
Merged
Use flake8-simplify #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
finswimmer
approved these changes
Jan 24, 2022
| @@ -1,6 +1,6 @@ | |||
| [flake8] | |||
| max-line-length = 88 | |||
| ignore = E501, E203, W503, ANN101, ANN102 | |||
| ignore = E501, E203, W503, ANN101, ANN102, SIM106 | |||
There was a problem hiding this comment.
I see that we ignore SIM106 in poetry as well. So I'm fine here. In many cases this warning helps to improve the code. But I've no idea how often it is not helpful in our cases. Maybe we should evaluate it some point later, and only ignore it case-by-case then.
bostonrwalker
pushed a commit
to bostonrwalker/poetry-core
that referenced
this pull request
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates-to: python-poetry/poetry#4776
flake8-simplify has already been introduced for poetry in python-poetry/poetry#4798