Marker simplifications #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
radoering
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Looks good to me. 👍 I'm currently on the same track because every marker simplification makes python-poetry/poetry#4695 better - just grasping for some higher hanging fruit. I hope I can reach some. 😉
Merged
This was referenced Feb 11, 2022
finswimmer
approved these changes
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry#
Markers get complicated; I've no intention of trying to solve this in full generality but here are a couple of pieces of low-hanging fruit to improve some cases.
In particular the first commit was motivated by a real life project in which
poetry exportgave the markerpython_version >= "3.6" or python_version >= "3.6", which looked a bit sad.