recalculate python markers on dependency more often #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimbleby
force-pushed
the
test-for-bad-python-version
branch
2 times, most recently
from
f3596c5
to
9ac4ebe
Compare
dimbleby
changed the title
|
now including a proposed fix |
radoering
previously approved these changes
Feb 6, 2022
There was a problem hiding this comment.
Looks good to me. I wonder if it may break some code that exploited the current behavior (as in the case of the pretty_constraint fix). Nevertheless, seems to be correct anyway and since all tests are passing, I think it could be merged.
Merged
Updating a marker in a way that removes python version constraints fails to remove the python version constraint
... when updating the marker
dimbleby
force-pushed
the
test-for-bad-python-version
branch
from
d3b11de
to
4bb8320
Compare
|
(rebased to resolve conflicts after other MRs were merged) |
|
Kudos, SonarCloud Quality Gate passed!
|
radoering
approved these changes
Feb 26, 2022
neersighted
approved these changes
Feb 28, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating a marker in a way that removes python version constraints fails to remove the python version constraint
Not for merging, until there's a fix! This is a demonstration of "bug 2" per python-poetry/poetry#5154