improve detection of Any marker union #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimbleby
force-pushed
the
another-marker-simplification
branch
from
5db98f3
to
9cd9861
Compare
|
Nice. I'm just wondering if "overlapped" is the correct word. That sounds like "the intersection is not empty". However, the variable only becomes True if one marker is a subset of the other, doesn't it? After reading the introduction about subsets at Wikipedia, I think "contained" or "included" may be better suited than "overlapped". |
|
Well it's an improvement on "intersected"! But I agree that "included" is better, will change. |
dimbleby
force-pushed
the
another-marker-simplification
branch
from
9cd9861
to
31e056f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
radoering
approved these changes
Feb 13, 2022
2 tasks
finswimmer
approved these changes
Feb 26, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry#
Another trivial simplification of markers