semver/pep508: handle wildcard exclusions #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@radoering since you looked at the last semver fix; can you take a peek here too? |
radoering
previously requested changes
May 3, 2022
abn
force-pushed
the
fix-single-version-range-exclusion
branch
from
43d5d27
to
663c54d
Compare
abn
force-pushed
the
fix-single-version-range-exclusion
branch
3 times, most recently
from
ecd9435
to
00193c8
Compare
radoering
previously requested changes
May 6, 2022
There was a problem hiding this comment.
Wow, definitively more extensive than I would have expected. But since it is encapsulated in its own method and you already know the goal of the long else branch after reading the short if branch it is not that difficult to follow. And since the test coverage seems fine, I'm fine with it for now.
Just two minor nitpicks (see comments).
abn
force-pushed
the
fix-single-version-range-exclusion
branch
from
00193c8
to
acb2336
Compare
Prior to this change, when exporting PEP 508 strings for dependencies, wildcard exclusion constraints like `!=2.0.*` were incorrectly serialised as invalid PEP 508 due to how version unions were serialsed. This change allows for determining if a version union is a single wildcard range exclusion, and if so serialise it appropriately. Resolves: python-poetry/poetry#5470
abn
force-pushed
the
fix-single-version-range-exclusion
branch
from
acb2336
to
2875257
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
radoering
approved these changes
May 6, 2022
dimbleby
reviewed
May 12, 2022
Merged
bostonrwalker
pushed a commit
to bostonrwalker/poetry-core
that referenced
this pull request
Aug 29, 2022
Prior to this change, when exporting PEP 508 strings for dependencies, wildcard exclusion constraints like `!=2.0.*` were incorrectly serialised as invalid PEP 508 due to how version unions were serialised. This change allows for determining if a version union is a single wildcard range exclusion, and if so serialise it appropriately. Resolves: python-poetry/poetry#5470
DavidVujic
pushed a commit
to DavidVujic/poetry-core
that referenced
this pull request
Aug 31, 2022
Prior to this change, when exporting PEP 508 strings for dependencies, wildcard exclusion constraints like `!=2.0.*` were incorrectly serialised as invalid PEP 508 due to how version unions were serialised. This change allows for determining if a version union is a single wildcard range exclusion, and if so serialise it appropriately. Resolves: python-poetry/poetry#5470
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, when exporting PEP 508 strings for dependencies, wildcard exclusion constraints like
!=2.0.*were incorrectly serialised as invalid PEP 508 due to how version unions were serialsed.This change allows for determining if a version union is a single wildcard range exclusion, and if so serialise it appropriately.
Resolves: python-poetry/poetry#5470
PS: Not entirely sure if this is the best fix, but it does the trick for now. Not entirely happy with the determination logic, if anyone has a better approach please do share.
Additionally, during testing it was identified that the
X_CONSTRAINTpattern mattaching when parsing constraints ignores any non semver versions (eg: calver). While the parser is in the "semver" package, since Poetry needs to support PEP440 based constraints, this should be improved. Will propose a fix in another PR.