Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flake8 additional dependencies #362

Conversation

mkniewallner
Copy link
Member

  • Added tests for changed code. Not applicable
  • Updated documentation for changed code. Not applicable

Update all flake8 additional dependencies.

This PR also updates flake8 configuration to use extend-ignore instead of ignore, to avoid overriding the default ignore list that could be set by some plugins (see flake8 documentation for more information).
poetry already uses extend-ignore, so this will also make the 2 projects more aligned.

Changelogs:

Per flake8 documentation (https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-extend-ignore),
the difference with `ignore` is that "this option can be used to selectively add individual codes without overriding the default list entirely", meaning that the default ignore list provided by plugins will not be overriden.
@sonarcloud
Copy link

sonarcloud bot commented May 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

.flake8 Show resolved Hide resolved
@Secrus
Copy link
Member

Secrus commented May 21, 2022

This is great, I would love to see the same PR in poetry itself.

Copy link
Member

@branchvincent branchvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@branchvincent branchvincent merged commit 471302b into python-poetry:master May 23, 2022
@mkniewallner mkniewallner deleted the bump-flake8-additional-dependencies branch May 23, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants