Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some GitHub actions improvements #364

Merged

Conversation

mkniewallner
Copy link
Member

@mkniewallner mkniewallner commented May 22, 2022

  • Added tests for changed code. Not applicable
  • Updated documentation for changed code. Not applicable

Bunch of improvements on GitHub Actions workflows to:

  • bump all actions/* actions versions
  • define the default shell to use, to avoid duplication
  • bootstrap Poetry through install.python-poetry.org rather than the deprecated install-poetry.py script

Also needed to update the name for PyPy from pypy3 to pypy-3.7, since https://github.com/actions/setup-python/releases/tag/v3.0.0 deprecated the usage of pypy3 keyword for the more explicit pypy-3.x pattern.
pypy3 used to correspond to pypy-3.6 and not pypy-3.7, but since Poetry dropped support for Python 3.6, I thought it may be better to test against PyPy 3.7.

Note: Since pypy3 is a required status check, the CI waits for this job to be run (which will not happen), but you can see the job passing here.

@sonarcloud
Copy link

sonarcloud bot commented May 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mkniewallner mkniewallner marked this pull request as ready for review May 22, 2022 12:58
@neersighted
Copy link
Member

@abn or @sdispater need to twiddle the required checks to allow merging this, but LGTM!

@abn
Copy link
Member

abn commented May 23, 2022

@neersighted replaced pypy3 with pypy-3. 7.

@neersighted neersighted merged commit c92286f into python-poetry:master May 23, 2022
@mkniewallner mkniewallner deleted the github-actions-improvements branch July 13, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants