Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker fixes #380

Merged
merged 2 commits into from
May 29, 2022
Merged

Marker fixes #380

merged 2 commits into from
May 29, 2022

Conversation

dimbleby
Copy link
Contributor

@dimbleby dimbleby commented May 28, 2022

First fix is I think cosmetic in unhittable code, the second finds a new marker simplification at intersection - code is analogous to the similar case in unions

elif (
isinstance(constraint_union, VersionConstraint)
and constraint_union.is_simple()
):
new_markers[i] = SingleMarker(
mark.name, constraint_union
)
included = True

without the fix the intersection looks like ... and python_version <= "3.6" and python_version >= "3.6"

pretty sure that ~= are always ">=" and "<" so this is only a cosmetic
improvement
@sonarcloud
Copy link

sonarcloud bot commented May 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@neersighted neersighted merged commit dfd1b39 into python-poetry:main May 29, 2022
@dimbleby dimbleby deleted the marker-fixes branch May 29, 2022 09:50
@radoering radoering mentioned this pull request Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants