add setter for version on ProjectPackage #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcavagnolo
force-pushed
the
version-setter
branch
2 times, most recently
from
8599306
to
853f2d5
Compare
2 tasks
bcavagnolo
force-pushed
the
version-setter
branch
from
853f2d5
to
02db9a8
Compare
This enables support for dynamically setting the package version (e.g., from a plugin) Resolves: python-poetry/poetry#5493
bcavagnolo
force-pushed
the
version-setter
branch
from
02db9a8
to
2d383c2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
I just added a test that the hash does not change and removed the todo. Iirc, we've added |
radoering
approved these changes
Aug 26, 2022
bostonrwalker
pushed a commit
to bostonrwalker/poetry-core
that referenced
this pull request
Aug 29, 2022
This enables support for dynamically setting the package version (e.g., from a plugin) Co-authored-by: Randy Döring <30527984+radoering@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables support for dynamically setting the package version
(e.g., from a plugin)
Resolves: python-poetry/poetry#6223