prefer to avoid casts #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
neersighted
force-pushed
the
typechecking
branch
from
16fdf6f
to
93ac8a9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
2 tasks
neersighted
approved these changes
Sep 17, 2022
neersighted
added a commit
to neersighted/poetry-core
that referenced
this pull request
Oct 5, 2022
This reverts commit 743e09c. At runtime, during consumption via the prepare_metadata_for_build_wheel, API, some of these values were in fact not what their typing was asserted to be. This would cause a failure when the assertion failed.
neersighted
added a commit
that referenced
this pull request
Oct 5, 2022
This reverts commit 743e09c. At runtime, during consumption via the prepare_metadata_for_build_wheel, API, some of these values were in fact not what their typing was asserted to be. This would cause a failure when the assertion failed.
dimbleby
added a commit
to dimbleby/poetry-core
that referenced
this pull request
Oct 5, 2022
but this time with more relaxed type assertions where appropriate
dimbleby
added a commit
to dimbleby/poetry-core
that referenced
this pull request
Oct 5, 2022
but this time with more relaxed type assertions where appropriate
neersighted
pushed a commit
to dimbleby/poetry-core
that referenced
this pull request
Oct 12, 2022
but this time with more relaxed type assertions where appropriate
neersighted
pushed a commit
that referenced
this pull request
Oct 12, 2022
but this time with more relaxed type assertions where appropriate
DavidVujic
pushed a commit
to DavidVujic/poetry-core
that referenced
this pull request
Oct 16, 2022
but this time with more relaxed type assertions where appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prefer to avoid
cast. If you're wrong, you never get to find out.It turns out that some of these were wrong, some tomlkit things are apparently
Tableand notContainer.