Refactor constraints structure #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radoering
force-pushed
the
refactor-constraints-structure
branch
from
63533ae
to
ef6b584
Compare
radoering
force-pushed
the
refactor-constraints-structure
branch
from
ef6b584
to
ac7a3be
Compare
…_ into parser module and rename module for constraint parsing of version constraints from helpers to parser
|
Kudos, SonarCloud Quality Gate passed!
|
mkniewallner
approved these changes
Sep 24, 2022
This was referenced Oct 3, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes, just moved two packages:
poetry.core.packages.constraints->poetry.core.constraints.genericpoetry.core.semver->poetry.core.constraints.versionI've always found it very confusing that the two types of constraints are distributed between
poetry.core.packages.constraintsandpoetry.core.semver. It's not even clear anymore why the first one is belowpackagesand why the second one is calledsemver. Of course, there is some semver related stuff in between the version constraints but the constraints are far from being limited to semver.In my opinion moving these packages results in a clearer structure that makes it easier to navigate the code for new contributors.
In order to avoid breakage, I only deprecated and forwarded the old packages.
The commits should probably NOT be squashed so that the rename can be recognized in git history.