Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-existent path dependencies - reloaded #520

Merged
merged 4 commits into from
Jan 22, 2023

Conversation

radoering
Copy link
Member

@radoering radoering commented Nov 12, 2022

Resolves: python-poetry/poetry#668
Resolves: python-poetry/poetry#6828

Supersedes: #210, #507

Requires: python-poetry/poetry#6844 (to preserve comprehensible output in case of error)

Note: Commits should not be squashed.

  • Added tests for changed code.
  • Updated documentation for changed code.

Secrus
Secrus previously requested changes Nov 13, 2022
src/poetry/core/packages/path_dependency.py Show resolved Hide resolved
radoering and others added 4 commits January 22, 2023 15:52
* print warning instead of raising an error in __init__ (allows `poetry lock --no-update` with missing locked path dependency that has been removed from pyproject.toml)
* introduce explicit `validate` method

Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@neersighted neersighted enabled auto-merge (rebase) January 22, 2023 17:20
@neersighted neersighted merged commit 5a6a250 into python-poetry:main Jan 22, 2023
@adriangb
Copy link
Contributor

Awesome glad to see this in!

@dndn10
Copy link

dndn10 commented Feb 21, 2023

Hi, is this feature supposed to allow the usage of poetry install without having the actual path dependencies in the filesystem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants