Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for handling of version ranges #645

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Draft

Fix for handling of version ranges #645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/poetry/core/constraints/version/version_range_constraint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def allowed_max(self) -> Version | None:
# The exclusive ordered comparison <V MUST NOT allow a pre-release
# of the specified version unless the specified version is itself a pre-release.
# https://peps.python.org/pep-0440/#exclusive-ordered-comparison
return self.max.first_devrelease()
return self.max.before_first_devrelease()

def allows_lower(self, other: VersionRangeConstraint) -> bool:
_this, _other = self.allowed_min, other.allowed_min
Expand Down
9 changes: 9 additions & 0 deletions src/poetry/core/version/pep440/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,15 @@ def first_prerelease(self: T) -> T:
pre=ReleaseTag(RELEASE_PHASE_ID_ALPHA),
)

def before_first_devrelease(self: T) -> T:
return self.__class__(
epoch=self.epoch,
release=self.release,
pre=self.pre,
post=self.post,
dev=_NEG_INF_TAG,
)

def first_devrelease(self: T) -> T:
return self.__class__(
epoch=self.epoch,
Expand Down