Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alter rev-parse syntax to support msys git #69

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Alter rev-parse syntax to support msys git #69

merged 1 commit into from
Aug 24, 2020

Commits on Aug 24, 2020

  1. Alter rev-parse syntax to support msys git 

    On windows, msys and cygwin versions of git need braces to be escaped when they
are invoked via subprocess.  (This appears to be is a side effect of the machinery
that converts windows paths to posix-like paths for the executable).

If they are not escaped, then "rev^{commit]" becomes a meaningless "rev^commit"
to an msys git, resulting in an error.

In contrast, we do not want to escape the braces if passing "rev^{commit}" to any
other form of git.  We can avoid having to decide whether escaping is needed by
using the alternative notation "^0".
    @donkopotamus
    donkopotamus committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    14e8b18 View commit details
    Browse the repository at this point in the history