allow appending deployment key to username (#2062) #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new (vcs.git): extract user credential (passord, deployment key, ...) from git url change (vcs.git): change order of init arguments for `ParsedUrl` change (vcs.git): make user, password, port, name and rev optional for `ParsedUrl`
…olean whether the ParsedUrl contains a secret like a password
2 tasks
|
Thanks for this, @finswimmer! I noticed one thing that it doesn't explicitly tests for / address is using Personal Access Tokens (python-poetry/poetry#2348). It might work, but would be nice to add a test for it to avoid issues. GitHub docs about it. Also, is there anything that I can contribute on this that could help speed things up? Thanks! |
|
Bumping this up again, @finswimmer, to ask if there's any specific areas I can help building / supporting that can help speed this up? Thanks for all your work! |
|
@finswimmer : I took a stab at the remainder items here that'd help in resolving python-poetry/poetry#2062 and python-poetry/poetry#2348, and based it off of the branch for this PR. finswimmer#1 |
2 tasks
|
Any news here?!? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows appending deployment keys to usernames as used by gitlab.
Furthermore a new property
is_unsafeis introduced forParsedUrl, which can be used for cli command likepoetry addto easily return whether the git dependency contains a password.According to gitlab's docs a
+is allowed in usernames. This is fixed as well.Fixes: python-poetry/poetry#2062
(This was initially submitted to the poetry repository: python-poetry/poetry#2169)
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!