Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use resolved references for vcs dependencies #213

Merged
merged 3 commits into from Sep 12, 2023
Merged

Use resolved references for vcs dependencies #213

merged 3 commits into from Sep 12, 2023

Conversation

koffie
Copy link
Contributor

@koffie koffie commented Jun 17, 2023

Fixes #35

@koffie koffie marked this pull request as draft June 17, 2023 09:52
@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@koffie
Copy link
Contributor Author

koffie commented Jun 17, 2023 •
edited

once there is a releasy of poetry-core that includes the changes of 1.7.0.dev0 the pyproject.toml should be updated to use that release and this PR should be good to go. The only pipeline failure is on 3.7, however that is not so strange since the most recent poetry and poetry-core versions dropped support for python 3.7.

@koffie koffie marked this pull request as ready for review September 11, 2023 09:46
@koffie
Copy link
Contributor Author

koffie commented Sep 11, 2023

After the release of poetry 1.6.0 which contains the necessary changes, this one is now ready for review.

@radoering
Copy link
Member

radoering commented Sep 11, 2023 •
edited

Can you please relock with Poetry 1.6.1 (use Poetry 1.6.1 to create the lockfile)?

@koffie
Copy link
Contributor Author

koffie commented Sep 12, 2023

Can you please relock with Poetry 1.6.1 (use Poetry 1.6.1 to create the lockfile)?

Done!

@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@radoering radoering merged commit 4670b0c into python-poetry:main Sep 12, 2023
15 checks passed
This was referenced Oct 30, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radoering radoering radoering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

poetry export uses branch name for VCS dependencies rather than resolved commit hash
2 participants
@koffie @radoering